difin commented on code in PR #5792:
URL: https://github.com/apache/hive/pull/5792#discussion_r2079773368
##########
iceberg/iceberg-handler/src/test/queries/positive/iceberg_major_compaction_single_partition.q:
##########
@@ -29,19 +29,19 @@ create table ice_orc_wo_evo (
first_name string,
last_name string
)
-partitioned by (dept_id bigint,
+partitioned by (dept_id decimal(10, 2),
Review Comment:
Same, to increase test coverage of partition field data types in iceberg
compaction. Yes, `dept_id` wouldn't likely be a decimal in a real world, but it
is only a field name which doesn't affect anything?
Changed the field name to 'cost' which is suitable for this data type.
##########
iceberg/iceberg-handler/src/test/queries/positive/iceberg_major_compaction_single_partition_with_evolution.q:
##########
@@ -29,42 +29,42 @@ create table ice_orc (
last_name string,
registration_date date
)
-partitioned by (dept_id bigint,
+partitioned by (dept_id float,
Review Comment:
Changed the field name to 'cost' which is suitable for this data type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
