difin commented on code in PR #5792: URL: https://github.com/apache/hive/pull/5792#discussion_r2079793497
########## iceberg/iceberg-handler/src/test/queries/positive/iceberg_major_compaction_single_partition_with_evolution2.q: ########## @@ -28,37 +28,37 @@ set hive.merge.tezfiles=true; create table ice_orc ( a string ) -partitioned by (b bigint) +partitioned by (b double) Review Comment: I remember on another PR you mentioned that there are already too many q-tests and precommit runs for too long time. These changes of data types do not change what these tests test, but increase coverage on different partition key data types. Are you ok if I correct field names to make them logically suitable to their new data types and keep the data type changes in the few q-tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org