difin commented on code in PR #5792:
URL: https://github.com/apache/hive/pull/5792#discussion_r2079745804
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergQueryCompactor.java:
##########
@@ -96,16 +106,46 @@ public boolean run(CompactorContext context) throws
IOException, HiveException,
throw new HiveException(ErrorMsg.COMPACTION_NO_PARTITION);
}
} else {
- long partitionHash = IcebergTableUtil.getPartitionHash(icebergTable,
partSpec);
+ Pair<Integer, StructProjection> partSpecPair =
+ IcebergTableUtil.getPartitionSpecIdAndStruct(icebergTable, partSpec);
Review Comment:
It is done to find the specId and partition struct that correspond to the
given partition name in human readable format and then to build a condition on
files meta-table with constraints on `files.partition` struct values. I don't
see how all this logic with all the transformations can be implemented only in
SQL in the main query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
