deniskuzZ commented on code in PR #5807:
URL: https://github.com/apache/hive/pull/5807#discussion_r2082189061
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/StatsUpdater.java:
##########
@@ -54,15 +57,13 @@ public final class StatsUpdater {
*/
public void gatherStats(CompactionInfo ci, HiveConf hiveConf,
String userName, String compactionQueueName,
- IMetaStoreClient msc) {
+ IMetaStoreClient msc, Map<String, String>
tableProperties) {
try {
if (msc == null) {
throw new IllegalArgumentException("Metastore client is
missing");
}
- HiveConf conf = new HiveConf(hiveConf);
- //so that Driver doesn't think it's already in a transaction
- conf.unset(ValidTxnList.VALID_TXNS_KEY);
+ HiveConf conf = createConfiguration(hiveConf, compactionQueueName,
tableProperties, ci.getProperties());
Review Comment:
can we reuse `Util.overrideConfProps(conf, ci, tableProperties)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
