deniskuzZ commented on code in PR #5807:
URL: https://github.com/apache/hive/pull/5807#discussion_r2082193611
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/StatsUpdater.java:
##########
@@ -86,15 +87,34 @@ public void gatherStats(CompactionInfo ci, HiveConf
hiveConf,
} else {
sb.append(" noscan");
}
- LOG.info(ci + ": running '" + sb + "'");
- if (compactionQueueName != null && compactionQueueName.length() >
0) {
- conf.set(TezConfiguration.TEZ_QUEUE_NAME, compactionQueueName);
- }
+
+ LOG.info("{}: running '{}'", ci, sb);
SessionState sessionState =
DriverUtils.setUpAndStartSessionState(conf, userName);
DriverUtils.runOnDriver(conf, sessionState, sb.toString());
} catch (Throwable t) {
- LOG.error(ci + ": gatherStats(" + ci.dbname + "," + ci.tableName +
"," + ci.partName +
- ") failed due to: " + t.getMessage(), t);
+ LOG.error("{}: gatherStats({},{},{}) failed due to: {}",
+ ci, ci.dbname, ci.tableName, ci.partName, t.getMessage(), t);
}
}
+
+ HiveConf createConfiguration(
+ HiveConf sourceConf,
+ String compactionQueueName,
+ Map<String, String> tableProperties,
+ Map<String, String> ciProperties) {
+
+ HiveConf conf = new HiveConf(sourceConf);
+
+ //so that Driver doesn't think it's already in a transaction
+ conf.unset(ValidTxnList.VALID_TXNS_KEY);
+
+ overrideProps(conf, tableProperties);
Review Comment:
see https://github.com/apache/hive/pull/5807/files#r2082189061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
