deniskuzZ commented on code in PR #5780:
URL: https://github.com/apache/hive/pull/5780#discussion_r2135638784
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -1928,9 +1928,8 @@ private void create_dataconnector_core(RawStore ms, final
DataConnector connecto
boolean success = false;
Map<String, String> transactionalListenersResponses =
Collections.emptyMap();
try {
- firePreEvent(new PreCreateDataConnectorEvent(connector, this));
-
ms.openTransaction();
+ firePreEvent(new PreCreateDataConnectorEvent(connector, this));
Review Comment:
What is the point? We open a txn, throw an exception in `firePreEvent`, and
then abort txn?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
