Indhumathi27 commented on code in PR #6013:
URL: https://github.com/apache/hive/pull/6013#discussion_r2273150525
##########
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/DynamicPartitionFileRecordWriterContainer.java:
##########
@@ -88,7 +90,8 @@ public DynamicPartitionFileRecordWriterContainer(
this.dynamicContexts = new HashMap<String,
org.apache.hadoop.mapred.TaskAttemptContext>();
this.dynamicObjectInspectors = new HashMap<String, ObjectInspector>();
this.dynamicOutputJobInfo = new HashMap<String, OutputJobInfo>();
- this.HIVE_DEFAULT_PARTITION_VALUE =
HiveConf.getVar(context.getConfiguration(),
HiveConf.ConfVars.DEFAULT_PARTITION_NAME);
+ this.HIVE_DEFAULT_PARTITION_VALUE =
PartitionUtils.getDefaultPartitionName(tbl.getParameters(),
+ HiveConf.getVar(context.getConfiguration(),
HiveConf.ConfVars.DEFAULT_PARTITION_NAME));
Review Comment:
can you move `HiveConf.getVar(context.getConfiguration(),
HiveConf.ConfVars.DEFAULT_PARTITION_NAME)` inside getDefaultPartitionName
method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
