Re: [PR] HIVE-29116 : Create a DDL for setting hive default partition name at the table level [hive]

[via GitHub]

vikramahuja1001 commented on code in PR #6013:
URL: https://github.com/apache/hive/pull/6013#discussion_r2276323684


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java:
##########
@@ -888,7 +887,7 @@ public boolean generateSqlFilterForPushdown(String catName, 
String dbName, Strin
     result.catName = catName;
     result.filter = PartitionFilterGenerator.generateSqlFilter(catName, 
dbName, tableName,
         partitionKeys, tree, result.params, result.joins, dbHasJoinCastBug,
-        ((defaultPartitionName == null) ? defaultPartName : 
defaultPartitionName),
+        ((defaultPartitionName == null) ? getDefaultPartitionName(tableParams, 
conf ) : defaultPartitionName),

Review Comment:
   done



##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -3352,12 +3352,13 @@ public List<String> listPartitionNames(String catName, 
String dbName, String tab
   public List<String> listPartitionNames(final String catName, final String 
dbName, final String tblName,
       final String defaultPartName, final byte[] exprBytes,
       final String order, final int maxParts) throws MetaException, 
NoSuchObjectException {
-    final String defaultPartitionName = 
getDefaultPartitionName(defaultPartName);
+    final String defaultPartitionName = 
getDefaultPartitionName(defaultPartName,
+            ensureGetMTable(catName, dbName, tblName).getParameters());
     final boolean isEmptyFilter = exprBytes.length == 1 && exprBytes[0] == -1;
     ExpressionTree tmp = null;
     if (!isEmptyFilter) {
       tmp = PartFilterExprUtil.makeExpressionTree(expressionProxy, exprBytes,
-          getDefaultPartitionName(defaultPartName), conf);
+              defaultPartitionName, conf);

Review Comment:
   Sure, done



##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -4761,7 +4771,7 @@ protected boolean 
canUseDirectSql(GetHelper<List<Partition>> ctx) throws MetaExc
           // if there are more than one filter string we AND them together
           initExpressionTree();
           return directSql.generateSqlFilterForPushdown(table.getCatName(), 
table.getDbName(), table.getTableName(),
-                  table.getPartitionKeys(), tree, null, filter);
+                  table.getPartitionKeys(), tree, null, filter, 
ctx.table.getParameters());

Review Comment:
   Changed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org