vikramahuja1001 commented on code in PR #6013:
URL: https://github.com/apache/hive/pull/6013#discussion_r2276324166


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java:
##########
@@ -3441,4 +3440,12 @@ private boolean shouldGetConstraintFromRawStore(String 
catName, String dbName, S
     return !shouldCacheTable(catName, dbName, tblName) || (canUseEvents && 
rawStore.isActiveTransaction())
         || !sharedCache.isTableConstraintValid(catName, dbName, tblName);
   }
+
+  public static String getDefaultPartitionName(Map<String, String> 
tableParams, Configuration conf) {

Review Comment:
   Done. HiveMetaStoreChecker has the code for this now.



##########
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/DynamicPartitionFileRecordWriterContainer.java:
##########
@@ -88,7 +90,8 @@ public DynamicPartitionFileRecordWriterContainer(
     this.dynamicContexts = new HashMap<String, 
org.apache.hadoop.mapred.TaskAttemptContext>();
     this.dynamicObjectInspectors = new HashMap<String, ObjectInspector>();
     this.dynamicOutputJobInfo = new HashMap<String, OutputJobInfo>();
-    this.HIVE_DEFAULT_PARTITION_VALUE = 
HiveConf.getVar(context.getConfiguration(), 
HiveConf.ConfVars.DEFAULT_PARTITION_NAME);
+    this.HIVE_DEFAULT_PARTITION_VALUE = 
PartitionUtils.getDefaultPartitionName(tbl.getParameters(),
+            HiveConf.getVar(context.getConfiguration(), 
HiveConf.ConfVars.DEFAULT_PARTITION_NAME));

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to