difin commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2277306621
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HMSTablePropertyHelper.java:
##########
@@ -236,26 +172,20 @@ public static Properties
getCatalogProperties(org.apache.hadoop.hive.metastore.a
SerDeInfo serdeInfo = hmsTable.getSd().getSerdeInfo();
if (serdeInfo != null) {
- serdeInfo.getParameters().entrySet().stream()
- .filter(e -> e.getKey() != null && e.getValue() != null).forEach(e
-> {
- String icebergKey =
HMSTablePropertyHelper.translateToIcebergProp(e.getKey());
- properties.put(icebergKey, e.getValue());
- });
+ Map<String, String> serdeParameters =
Optional.ofNullable(serdeInfo.getParameters()).orElseGet(Maps::newHashMap);
Review Comment:
Here it is handled, added safety around it in other hive-iceberg places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
