difin commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2277508776
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java:
##########
@@ -266,13 +266,17 @@ static Optional<Catalog> loadCatalog(Configuration conf,
String catalogName) {
/**
* Collect all the catalog specific configuration from the global hive
configuration.
* @param conf a Hadoop configuration
- * @param catalogName name of the catalog
+ * @param catalogType type of the catalog
* @return complete map of catalog properties
*/
- private static Map<String, String> getCatalogProperties(Configuration conf,
String catalogName) {
+ private static Map<String, String> getCatalogProperties(Configuration conf,
String catalogType) {
Map<String, String> catalogProperties = Maps.newHashMap();
- String keyPrefix = REST_CATALOG_TYPE.equals(catalogName) ?
- InputFormatConfig.CATALOG_REST_CONFIG_PREFIX :
InputFormatConfig.CATALOG_CONFIG_PREFIX + catalogName;
+
+ String icebergCatalogType = MetastoreConf.get(conf,
MetastoreConf.ConfVars.HIVE_ICEBERG_CATALOG_TYPE.getHiveName());
+ final String catalogConfigPrefix = String.format("iceberg.%s-catalog.",
icebergCatalogType);
+
+ String keyPrefix = icebergCatalogType.equals(catalogType) ?
Review Comment:
reverted this part, it was a confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
