difin commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2277509179
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/client/HiveRESTCatalogClient.java:
##########
@@ -112,13 +123,15 @@ public void close() {
}
}
- private static Map<String, String> getCatalogPropertiesFromConf(
- Configuration conf) {
+ private static Map<String, String>
getCatalogPropertiesFromConf(Configuration conf) {
Map<String, String> catalogProperties = Maps.newHashMap();
+ String icebergCatalogType = MetastoreConf.get(conf,
MetastoreConf.ConfVars.HIVE_ICEBERG_CATALOG_TYPE.getHiveName());
+ final String catalogConfigPrefix = String.format("iceberg.%s-catalog.",
icebergCatalogType);
Review Comment:
Yes, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
