difin commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2283691233
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##########
@@ -324,6 +332,12 @@ public void
rollbackCreateTable(org.apache.hadoop.hive.metastore.api.Table hmsTa
@Override
public void commitCreateTable(org.apache.hadoop.hive.metastore.api.Table
hmsTable) {
+ String catalogType = MetastoreConf.get(conf,
MetastoreConf.ConfVars.HIVE_ICEBERG_CATALOG_TYPE.getHiveName());
+ if (catalogType != null && !catalogType.isEmpty()) {
+ // If the catalog type is set, we assume that the table has been created
in the delegate.createTable(request) call
Review Comment:
Added a more generic solution to `commitAlterTable` and `commitDropTable`.
There is no such method as `commitInsertTable` in Hive Iceberg hook.
`commitAlterTable` - do we need to update here if RESTCatalogClient doesn't
have alter table operation and this commit will not be called with rest catalog?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
