difin commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2283552162
##########
standalone-metastore/metastore-rest-catalog/src/test/java/org/apache/iceberg/rest/extension/HiveRESTCatalogServerExtension.java:
##########
@@ -42,7 +43,7 @@ public class HiveRESTCatalogServerExtension implements
BeforeAllCallback, Before
private final JwksServer jwksServer;
private final RESTCatalogServer restCatalogServer;
- private HiveRESTCatalogServerExtension(AuthType authType) {
+ private HiveRESTCatalogServerExtension(AuthType authType, Class<? extends
MetaStoreSchemaInfo> metaStoreSchemaClass) {
Review Comment:
Renamed to schemaInfoClass as you suggested.
Would do you mean if we need to externalize it?
##########
standalone-metastore/metastore-rest-catalog/src/test/java/org/apache/iceberg/rest/extension/HiveRESTCatalogServerExtension.java:
##########
@@ -42,7 +43,7 @@ public class HiveRESTCatalogServerExtension implements
BeforeAllCallback, Before
private final JwksServer jwksServer;
private final RESTCatalogServer restCatalogServer;
- private HiveRESTCatalogServerExtension(AuthType authType) {
+ private HiveRESTCatalogServerExtension(AuthType authType, Class<? extends
MetaStoreSchemaInfo> metaStoreSchemaClass) {
Review Comment:
Renamed to `schemaInfoClass` as you suggested.
Would do you mean if we need to externalize it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
