difin commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2283297297
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##########
@@ -492,6 +513,9 @@ private void
doPreAlterTable(org.apache.hadoop.hive.metastore.api.Table hmsTable
// all or some of its data files have not been written out using the
Iceberg writer, and therefore those data
// files do not contain Iceberg field IDs. This makes certain schema
evolution operations problematic, so we
// want to disable these ops for now using this new table prop
+ if (hmsTable.getParameters() == null) {
Review Comment:
reverted.
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##########
@@ -363,7 +383,8 @@ public void
preDropTable(org.apache.hadoop.hive.metastore.api.Table hmsTable, bo
if (deleteIcebergTable && Catalogs.hiveCatalog(conf, catalogProperties) &&
deleteData) {
// Store the metadata and the io for deleting the actual table data
try {
- String metadataLocation =
hmsTable.getParameters().get(BaseMetastoreTableOperations.METADATA_LOCATION_PROP);
+ String metadataLocation =
Optional.ofNullable(hmsTable.getParameters()).orElseGet(Maps::newHashMap)
Review Comment:
reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
