wecharyu commented on code in PR #5223: URL: https://github.com/apache/hive/pull/5223#discussion_r2294211036
########## standalone-metastore/metastore-client/src/main/java/org/apache/hadoop/hive/metastore/client/HookEnabledMetaStoreClient.java: ########## @@ -325,6 +327,21 @@ public List<Partition> dropPartitions(String catName, String dbName, String tblN return delegate.dropPartitions(catName, dbName, tblName, partExprs, options, context); } + @Override Review Comment: Nice catch, I want to preserve the use of `hook.preDropPartitions(table, context, partExprs);` at the beginning. Actually it could be removed here too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org