deniskuzZ commented on code in PR #5223:
URL: https://github.com/apache/hive/pull/5223#discussion_r2298153395


##########
standalone-metastore/metastore-client/src/main/java/org/apache/hadoop/hive/metastore/client/BaseMetaStoreClient.java:
##########
@@ -557,6 +561,32 @@ public final List<Partition> dropPartitions(String 
catName, String dbName, Strin
     return dropPartitions(catName, dbName, tblName, partExprs, options, null);
   }
 
+  @Override
+  public List<Partition> dropPartitions(String catName, String dbName, String 
tblName,
+      List<Pair<Integer, byte[]>> partExprs, PartitionDropOptions options, 
EnvironmentContext context)
+      throws NoSuchObjectException, MetaException, TException {
+    if (context == null) {
+      context = new EnvironmentContext();
+    }
+
+    if (context.getProperties() != null &&
+        
Boolean.parseBoolean(context.getProperties().get(SKIP_DROP_PARTITION))) {

Review Comment:
   in that case, should we drop this check from the `BaseMetastoreClient` and 
keep it just in `ThriftHiveMetastoreClient`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to