deniskuzZ commented on code in PR #5223:
URL: https://github.com/apache/hive/pull/5223#discussion_r2298151342
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:
##########
@@ -4080,8 +4097,8 @@ public List<Partition> dropPartitions(String dbName,
String tableName,
.map(ss -> ss.getTxnMgr().getCurrentTxnId()).orElse(0L);
dropOptions.setTxnId(txnId);
}
- List<org.apache.hadoop.hive.metastore.api.Partition> partitions =
getMSC().dropPartitions(dbName, tableName,
- partitionExpressions, dropOptions);
+ List<org.apache.hadoop.hive.metastore.api.Partition> partitions =
getMSC().dropPartitions(
+ tableName, partsSpec, dropOptions, null);
Review Comment:
not sure, however, passing NULLs isn't great either
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
