armitage420 commented on code in PR #5779:
URL: https://github.com/apache/hive/pull/5779#discussion_r2293029975
##########
serde/src/java/org/apache/hadoop/hive/serde2/avro/TypeInfoToSchema.java:
##########
@@ -159,7 +159,7 @@ private Schema createAvroPrimitive(TypeInfo typeInfo) {
case TIMESTAMP:
schema = AvroSerdeUtils.getSchemaFor("{" +
"\"type\":\"" + AvroSerDe.AVRO_LONG_TYPE_NAME + "\"," +
- "\"logicalType\":\"" + AvroSerDe.TIMESTAMP_TYPE_NAME + "\"}");
+ "\"logicalType\":\"" + AvroSerDe.TIMESTAMP_TYPE_NAME_MICROS + "\"}");
Review Comment:
<img width="3456" height="2234" alt="image"
src="https://github.com/user-attachments/assets/706b16d6-7240-4f91-8292-25e1dbd35a8b";
/>
The following part of code is _only used during hive table creation_ .
Essentially, when I create a timestamp column. The following change is not
going to affect users who still are inserting values with millis precision. And
now by adding TIMESTAMP_TYPE_NAME_MICROS as default, we will be providing
better precision on the same column. Hence, despite this change, backward
compatibility is ensured.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
