armitage420 commented on PR #5779: URL: https://github.com/apache/hive/pull/5779#issuecomment-3220831270
@SourabhBadhya The build is green, finally! :^) I hope you can review this when you have the time. Giving an overview of the changes since our last discussion, as it’s been a while: 1. It was mentioned to add specific columns for timestamp-millis/timestamp-micros => Avro’s logicalType is internal to each datatype. In our case, we are dealing with the timestamp type; hence, the column remains TIMESTAMP. The change is that the same column can now handle higher precision. 2. I had to add separate and specific tests for micros => This is done. I had edited some rows in qfiles to test microsecond precision; instead, I have now added extra rows. For these changes, I didn’t create new qfiles (per point 1), and thus we are testing the precision of the TIMESTAMP column when using the Avro file format. 3. Java code/clean-code related changes are done as mentioned. 4. The suggestion to follow syntax similar to Timestamp#toEpochMilli() — return localDateTime.toInstant(ZoneOffset.UTC).toEpochMilli() * 1000 + localDateTime.getNano() / 1000 — gives incorrect results. 5. The variable AvroSerDe.TIMESTAMP_TYPE_NAME is renamed to AvroSerDe.TIMESTAMP_TYPE_NAME_MILLIS, and we have introduced a new logical type AvroSerDe.TIMESTAMP_TYPE_NAME_MICROS to make the differentiation clear. 6. During testing of some AvroDeserialize scenarios while fixing the above tests, the correct logicalType for all kinds of schemas was not being detected. Hence, I have introduced a schema parser for the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
