armitage420 commented on code in PR #5779:
URL: https://github.com/apache/hive/pull/5779#discussion_r2293041227
##########
serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroObjectInspectorGenerator.java:
##########
@@ -227,7 +227,7 @@ public class TestAvroObjectInspectorGenerator {
" \"fields\" : [\n" +
" {\"name\":\"timestampField\", " +
" \"type\":\"" + AvroSerDe.AVRO_LONG_TYPE_NAME + "\", " +
- " \"logicalType\":\"" + AvroSerDe.TIMESTAMP_TYPE_NAME + "\"}" +
+ " \"logicalType\":\"" + AvroSerDe.TIMESTAMP_TYPE_NAME_MILLIS +
"\"}" +
Review Comment:
The only change made here is nomenclature, basically TIMESTAMP_TYPE_NAME
before used to mean TIMESTAMP_TYPE_NAME_MILLIS by default, but now that we have
added the an extra logical type TIMESTAMP_TYPE_NAME_MICROS, the differentiation
needed to be made between TIMESTAMP_TYPE_NAME and TIMESTAMP_TYPE_NAME_MICROS.
Hence, the test itself is not changed, TIMESTAMP_TYPE_NAME is now renamed to
TIMESTAMP_TYPE_NAME_MILLIS of the Avroserde class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
