okumin opened a new pull request, #6115:
URL: https://github.com/apache/hive/pull/6115
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA:
https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
Normalize license headers of all Java files.
The following ones are exceptional.
- `iceberg/**`: most of them are ported from `apache/iceberg`
-
[serde/src/java/org/apache/hadoop/hive/serde2/lazy/fast/StringToDouble.java](https://github.com/apache/hive/blob/master/serde/src/java/org/apache/hadoop/hive/serde2/lazy/fast/StringToDouble.java):
Looks like it was ported from another library
-
[llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/PriorityBlockingDeque.java](https://github.com/apache/hive/blob/master/llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/PriorityBlockingDeque.java):
Ditto
- `hbase-handler/src/test/org/apache/hadoop/hive/hbase/avro/*.java`:
Generated by Avro
-
`kafka-handler/src/test/gen/org/apache/hadoop/hive/kafka/SimpleRecord.java`:
Ditto
### Why are the changes needed?
Our CI strictly verifies license headers of new files. I suppose many people
copy and paste headers from existing files for convenience, so, I sometimes
observe CI failing because of the format of licence headers.
As additional bonuses, consistent headers will reduce legal risks and future
maintenance costs.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
I put the following configuration on `checkstyle/checkstyle.xml`,
`standalone-metastore/checkstyle/checkstyle.xml`, and
``storage-api/checkstyle/checkstyle.xml. After that, I ran `mvn
checkstyle:check`.
```xml
<?xml version="1.0"?>
<!DOCTYPE module PUBLIC
"-//Puppy Crawl//DTD Check Configuration 1.2//EN"
"http://www.puppycrawl.com/dtds/configuration_1_2.dtd";>
<module name="Checker">
<module name="Header">
<property name="headerFile" value="${config_loc}/asf.header"/>
<property name="fileExtensions" value="java"/>
</module>
</module>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
