simhadri-g commented on code in PR #6149:
URL: https://github.com/apache/hive/pull/6149#discussion_r2472764390


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java:
##########
@@ -3269,16 +3281,21 @@ public List<Void> run(List<String> input) throws 
Exception {
             input, Collections.emptyList(), -1);
         if (!partitionIds.isEmpty()) {
           String deleteSql = "delete from " + PART_COL_STATS + " where 
\"PART_ID\" in ( " + getIdListForIn(partitionIds) + ")";

Review Comment:
   the partitionIds is returned as long, and getIdListForIn(partitionIds) 
essentially calls Long.toString() which should output only digits, therefore no 
special characters can be introduced here. So, i think 
`getIdListForIn(partitionIds)` is safe.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to