kasakrisz commented on code in PR #6149:
URL: https://github.com/apache/hive/pull/6149#discussion_r2486058473
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java:
##########
@@ -3243,19 +3248,26 @@ public void deleteColumnStatsState(long tbl_id) throws
MetaException {
}
public boolean deleteTableColumnStatistics(long tableId, List<String>
colNames, String engine) {
- String deleteSql = "delete from " + TAB_COL_STATS + " where \"TBL_ID\" = "
+ tableId;
+ String deleteSql = "delete from " + TAB_COL_STATS + " where \"TBL_ID\" =
?";
+ List<Object> params = new ArrayList<>(colNames == null ? 2 :
colNames.size() + 2);
+ params.add(tableId);
+
if (colNames != null && !colNames.isEmpty()) {
- deleteSql += " and \"COLUMN_NAME\" in (" + colNames.stream().map(col ->
"'" + col + "'").collect(Collectors.joining(",")) + ")";
+ deleteSql += " and \"COLUMN_NAME\" in (" + makeParams(colNames.size()) +
")";
+ params.addAll(colNames);
}
+
if (engine != null) {
- deleteSql += " and \"ENGINE\" = '" + engine + "'";
+ deleteSql += " and \"ENGINE\" = ?";
+ params.add(engine);
Review Comment:
added test case to test engine with special character `'` in it's name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
