okumin commented on code in PR #6149:
URL: https://github.com/apache/hive/pull/6149#discussion_r2476544088
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java:
##########
@@ -3269,16 +3281,21 @@ public List<Void> run(List<String> input) throws
Exception {
input, Collections.emptyList(), -1);
if (!partitionIds.isEmpty()) {
String deleteSql = "delete from " + PART_COL_STATS + " where
\"PART_ID\" in ( " + getIdListForIn(partitionIds) + ")";
Review Comment:
I agree `getIdListForIn((Collection<Long>) partitionIds)` is safe, and we
don't need to update it in this patch as a short-term remediation. As a
long-term remediation, I'd say we should not have a habit of concatenating
strings since a single abuse and careless review can introduce a new
vulnerability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
