difin commented on code in PR #6218:
URL: https://github.com/apache/hive/pull/6218#discussion_r2610808264
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/CatalogUtils.java:
##########
@@ -82,6 +90,11 @@ public static Properties
getCatalogProperties(org.apache.hadoop.hive.metastore.a
hmsTable.getTableName()).toString());
}
+ if
(properties.get(TableProperties.METADATA_DELETE_AFTER_COMMIT_ENABLED).equals("false"))
{
+ properties.remove(TableProperties.METADATA_DELETE_AFTER_COMMIT_ENABLED);
Review Comment:
If these properties are always be present, we need to update a lot of unit
tests and q-tests whose output will be different. And also when `false`, they
are basically useless. That's why I thought to remove these properties when
`false`. Do you think we keep them and update tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
