difin commented on code in PR #6218:
URL: https://github.com/apache/hive/pull/6218#discussion_r2610852344
##########
data/conf/iceberg/llap/hive-site.xml:
##########
@@ -397,4 +397,9 @@
<name>hive.lock.sleep.between.retries</name>
<value>2</value>
</property>
+
+ <property>
+
<name>iceberg.catalog-default.write.metadata.delete-after-commit.enabled</name>
Review Comment:
If we drop `catalog-default.` it will cause ambiguity in
`CatalogUtils.getCatalogProperties` because:
- Default catalog prefix is `iceberg.catalog-default.`
- Named catalog prefix is `iceberg.catalog.<NAME>.`
```
public static Map<String, String> getCatalogProperties(Configuration conf,
String catalogName) {
Map<String, String> catalogProperties = Maps.newHashMap();
String keyPrefix = CATALOG_CONFIG_PREFIX + catalogName;
conf.forEach(config -> {
if
(config.getKey().startsWith(CatalogUtils.CATALOG_DEFAULT_CONFIG_PREFIX)) {
catalogProperties.putIfAbsent(
config.getKey().substring(CatalogUtils.CATALOG_DEFAULT_CONFIG_PREFIX.length()),
config.getValue());
} else if (config.getKey().startsWith(keyPrefix)) {
catalogProperties.put(
config.getKey().substring(keyPrefix.length() + 1),
config.getValue());
}
});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
