deniskuzZ commented on code in PR #6218:
URL: https://github.com/apache/hive/pull/6218#discussion_r2610896942
##########
data/conf/iceberg/llap/hive-site.xml:
##########
@@ -397,4 +397,9 @@
<name>hive.lock.sleep.between.retries</name>
<value>2</value>
</property>
+
+ <property>
+
<name>iceberg.catalog-default.write.metadata.delete-after-commit.enabled</name>
Review Comment:
why
````
public static Map<String, String> getCatalogProperties(Configuration conf,
String catalogName) {
Map<String, String> catalogProperties = Maps.newHashMap();
String namedPrefix = "iceberg.catalog." + catalogName + ".";
conf.forEach(config -> {
String key = config.getKey();
if (key.startsWith("iceberg.")) {
if (key.startsWith(namedPrefix)) {
// Named catalog overrides default
catalogProperties.put(
key.substring(namedPrefix.length()),
config.getValue());
} else {
// Default config for all catalogs
catalogProperties.putIfAbsent(
key.substring("iceberg.".length()),
config.getValue());
}
}
});
return catalogProperties;
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
