dengzhhu653 commented on code in PR #6240: URL: https://github.com/apache/hive/pull/6240#discussion_r2756573015
########## ql/src/test/results/clientpositive/llap/ppd_like_filter.q.out: ########## @@ -256,3 +256,51 @@ POSTHOOK: type: QUERY POSTHOOK: Input: default@test_tbl POSTHOOK: Input: default@test_tbl@b=d_%5C%25ae #### A masked pattern was here #### +PREHOOK: query: select * from test_tbl where b like 'a.*' Review Comment: I might be wrong, but this could make things even worse. The `makeJdoFilterForLike` assumes the input is a sql pattern, so for a `like`, this sql pattern might be working for both jdo and sql. Now we assume the `like` can be a jdo or sql filter, in `MetaStoreDirectSql` we try to transform the jdo to sql, how if the `like` is real sql based? say, `hello*` just wants to filter the partition name `hello*`. For me, this guess(gap) could be producing inconsistent result between jdo and sql for the same ObjectStore API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
