wecharyu commented on code in PR #6240: URL: https://github.com/apache/hive/pull/6240#discussion_r2766859455
########## ql/src/test/results/clientpositive/llap/ppd_like_filter.q.out: ########## @@ -256,3 +256,51 @@ POSTHOOK: type: QUERY POSTHOOK: Input: default@test_tbl POSTHOOK: Input: default@test_tbl@b=d_%5C%25ae #### A masked pattern was here #### +PREHOOK: query: select * from test_tbl where b like 'a.*' Review Comment: > if we disable the direct sql, it could give us a different answer for the same input. The result could be different before this patch just like the updated `ppd_like_filter.q` test shows, we are fixing it here. Pls correct me if I miss something. > If an ObjectStore API has implemented the direct sql or going to be, then for this API, I would suggest the sql type pattern for the filter. HMS users may not know the API details, it's a bit difficult for them to know which api should use sql filter and which one should use java pattern. In another word, such difference seems not friendly to users. I think we have 2 choices to keep consistency: 1. Declare in the user document that filter is SQL only, and escape the java pattern in JDO implement of each API. 2. Both direct implement and JDO implement supports java pattern and sql filter, which is what we do here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
