abstractdog commented on code in PR #6337:
URL: https://github.com/apache/hive/pull/6337#discussion_r2909991108
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java:
##########
@@ -609,25 +609,30 @@ public boolean equals(Object obj) {
return true;
}
- public List<FieldSchema> getPartCols() {
+ public List<FieldSchema> getPartCols(boolean needNonNativeParts) {
+
List<FieldSchema> partKeys = tTable.getPartitionKeys();
+
if (partKeys == null) {
partKeys = new ArrayList<>();
tTable.setPartitionKeys(partKeys);
}
+
+ if (hasNonNativePartitionSupport() && needNonNativeParts) {
+ partKeys = getStorageHandler().getPartitionKeys(this);
+ }
Review Comment:
depending on the input flag, the previous computation of partKeys becomes
redundant, this might be related to my above comment which encourages you to
use separate methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
