ramitg254 commented on code in PR #6337:
URL: https://github.com/apache/hive/pull/6337#discussion_r2910528650
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java:
##########
@@ -609,25 +609,30 @@ public boolean equals(Object obj) {
return true;
}
- public List<FieldSchema> getPartCols() {
+ public List<FieldSchema> getPartCols(boolean needNonNativeParts) {
Review Comment:
but since it violates clean code principles as @abstractdog mentioned so
for that reason I think a separate method is a better choice which is generic
to table.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
