ramitg254 commented on code in PR #6337:
URL: https://github.com/apache/hive/pull/6337#discussion_r2910520529
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java:
##########
@@ -609,25 +609,30 @@ public boolean equals(Object obj) {
return true;
}
- public List<FieldSchema> getPartCols() {
+ public List<FieldSchema> getPartCols(boolean needNonNativeParts) {
Review Comment:
there is a need to pass this parameter as there are couple of scenarios
where directly returning non native keys are problematic like in case of
queries like alter table conversion to iceberg table the new table hasn't
registered as an iceberg table so whenever it calls the newer implementation of
getPartCols it will return with `not an iceberg table exception` and there are
occurences in stats gathering where the newer implementation will fall into
derived stats logic of hive which we don't want as iceberg take care of stats
on its own and currently getPartCols returns empty list in those scenarios and
we don't run into any issues and with this boolean flag it was descriptive and
is able to handle those scenarios.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
