deniskuzZ commented on code in PR #6511:
URL: https://github.com/apache/hive/pull/6511#discussion_r3311288383
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/service/AcidCompactionService.java:
##########
@@ -211,32 +212,27 @@ public Boolean compact(Table table, CompactionInfo ci)
throws Exception {
// Don't start compaction or cleaning if not necessary
if (isDynPartAbort(table, ci)) {
- msc.markCompacted(CompactionInfo.compactionInfoToStruct(ci));
- compactionTxn.wasSuccessful();
+ compactionTxn.onCommit(() ->
msc.markCompacted(CompactionInfo.compactionInfoToStruct(ci)));
return false;
}
dir = getAcidStateForWorker(ci, sd, tblValidWriteIds);
if (!isEnoughToCompact(ci, dir, sd)) {
if (needsCleaning(dir, sd)) {
- msc.markCompacted(CompactionInfo.compactionInfoToStruct(ci));
+ compactionTxn.onCommit(() ->
msc.markCompacted(CompactionInfo.compactionInfoToStruct(ci)));
} else {
// do nothing
ci.errorMessage = "None of the compaction thresholds met, compaction
request is refused!";
LOG.debug(ci.errorMessage + " Compaction info: {}", ci);
- msc.markRefused(CompactionInfo.compactionInfoToStruct(ci));
+ compactionTxn.onCommit(() ->
msc.markRefused(CompactionInfo.compactionInfoToStruct(ci)));
+
}
- compactionTxn.wasSuccessful();
return false;
}
if (!ci.isMajorCompaction() &&
!CompactorUtil.isMinorCompactionSupported(conf, table.getParameters(), dir)) {
ci.errorMessage = "Query based Minor compaction is not possible for
full acid tables having raw format " +
"(non-acid) data in them.";
LOG.error(ci.errorMessage + " Compaction info: {}", ci);
- try {
- msc.markRefused(CompactionInfo.compactionInfoToStruct(ci));
- } catch (Throwable tr) {
- LOG.error("Caught an exception while trying to mark compaction {} as
failed: {}", ci, tr);
- }
+ compactionTxn.onAbort(() ->
msc.markRefused(CompactionInfo.compactionInfoToStruct(ci)));
Review Comment:
why we abort txn in case of markRefused? shouldn't we abort only in case
non-business exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
