deniskuzZ commented on code in PR #6511:
URL: https://github.com/apache/hive/pull/6511#discussion_r3318895495
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/service/AcidCompactionService.java:
##########
@@ -377,11 +376,14 @@ private LockRequest createLockRequest(CompactionInfo ci) {
return CompactorUtil.createLockRequest(conf, ci, txnId,
lockAndOpType.getKey(), lockAndOpType.getValue());
}
- /**
- * Mark compaction as successful. This means the txn will be committed;
otherwise it will be aborted.
- */
- void wasSuccessful() {
- this.successfulCompaction = true;
+ void markForCommit(ThrowingRunnable action) {
+ this.rollbackOnly = false;
+ this.onCommitSuccess = action;
+ }
+
+ void markForAbort(ThrowingRunnable action) {
+ this.rollbackOnly = true;
Review Comment:
this is redundant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
