kuczoram commented on code in PR #6511:
URL: https://github.com/apache/hive/pull/6511#discussion_r3322956558
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/service/AcidCompactionService.java:
##########
@@ -396,10 +396,18 @@ public void close() throws Exception {
//the transaction is about to close, we can stop heartbeating
regardless of it's state
CompactionHeartbeatService.getInstance(conf).stopHeartbeat(txnId);
} finally {
- if (successfulCompaction) {
- commit();
+ if (onCommitAction != null) {
+ try {
+ commit();
+ } catch (Exception e) {
+ abort();
+ if (onAbortAction != null) onAbortAction.run();
Review Comment:
Discussed this offline and decided not to have default onAbortAction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
