difin commented on code in PR #6449: URL: https://github.com/apache/hive/pull/6449#discussion_r3351004558
########## iceberg/iceberg-handler/src/test/results/positive/llap/iceberg_rest_catalog_hms.q.out: ########## @@ -68,8 +68,6 @@ CREATE EXTERNAL TABLE `ice_orc2`( `dept_id` bigint, `team_id` bigint, `company_id` bigint) -PARTITIONED BY ( Review Comment: This is related to your previous comment: https://github.com/apache/hive/pull/6449#discussion_r3347517089 Previously, `MetastoreUtil.toHiveTable(..)` was setting partition keys and this was causing failures in Iceberg views on partitioned base Iceberg tables. In this PR it was decided with Denys and Krisztian to set partition keys as empty in `MetastoreUtil.toHiveTable(..)` until HIVE-29633 is fixed. ``` // TODO: Revert after HIVE-29633 is fixed // result.setPartitionKeys(getPartitionKeys(table, table.spec().specId())); result.setPartitionKeys(Lists.newArrayList()); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
