difin commented on code in PR #6449:
URL: https://github.com/apache/hive/pull/6449#discussion_r3351089847


##########
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadTask.java:
##########
@@ -547,8 +547,9 @@ public static Task<?> createViewTask(MetaData metaData, 
String dbNameToLoadIn, H
       // texts using new DB name. Currently it refers to the source database 
name.
     }
 
-    CreateViewDesc desc = new CreateViewDesc(dbDotView, table.getCols(), null, 
table.getParameters(),
-            table.getPartColNames(), false, false, viewOriginalText, 
viewExpandedText, table.getPartCols());
+    CreateViewDesc desc = new CreateViewDesc(dbDotView, table.getCols(), null, 
table.getParameters(), 

Review Comment:
   We can use regular HMS client with Iceberg logical views too.
   
   HMS still has basic info about Iceberg views, like view identity (db, view 
name), but all the other info is coming from Iceberg metadata at query time, so 
I don't think there should be an issue here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to