difin commented on code in PR #6449:
URL: https://github.com/apache/hive/pull/6449#discussion_r3351884749
##########
common/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java:
##########
@@ -445,6 +445,7 @@ public enum ErrorMsg {
@Deprecated // kept for backwards reference
REPLACE_VIEW_WITH_MATERIALIZED(10400, "Attempt to replace view {0} with
materialized view", true),
REPLACE_MATERIALIZED_WITH_VIEW(10401, "Attempt to replace materialized view
{0} with view", true),
+ VIEW_STORAGE_HANDLER_UNSUPPORTED(10448, "Storage handler {0} doesn't support
external logical views", true),
Review Comment:
To me omitting the word 'logical' sounds ambiguous.
Also, we are adding support for more view types and we will have regular
hive view, hive matrialized view, Iceberg (logical) view, Iceberg materialized
view (your PR), I just thought it will help understanding what view type we are
referring to having 'logical' in the name.
@kasakrisz what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
