difin commented on code in PR #6506:
URL: https://github.com/apache/hive/pull/6506#discussion_r3530106353
##########
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/ParquetRecordReaderBase.java:
##########
@@ -164,18 +164,29 @@ protected ParquetInputSplit getSplit(
legacyConversionEnabled =
DataWritableReadSupport.getZoneConversionLegacy(fileMetaData.getKeyValueMetaData(),
conf);
- split = new ParquetInputSplit(finalPath,
- splitStart,
- splitLength,
- fileSplit.getLocations(),
- filteredBlocks,
- readContext.getRequestedSchema().toString(),
- fileMetaData.getSchema().toString(),
- fileMetaData.getKeyValueMetaData(),
- readContext.getReadSupportMetadata());
+ split = buildParquetInputSplit(finalPath,
readContext.getRequestedSchema());
return split;
}
+ private ParquetInputSplit buildParquetInputSplit(final Path finalPath, final
MessageType requestedSchema)
Review Comment:
Why was it required to replace the old split constructor with a new one for
quoted-identifier schema handling?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
