tanishq-chugh commented on code in PR #6506:
URL: https://github.com/apache/hive/pull/6506#discussion_r3545284928
##########
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/read/DataWritableReadSupport.java:
##########
@@ -438,6 +439,20 @@ public static MessageType getRequestedSchema(
}
}
+ public static MessageType getTableParquetSchema(Configuration configuration,
MessageType fileSchema,
+ Map<String, String> metadata) {
+ String columnNames = configuration.get(IOConstants.COLUMNS);
+ String columnTypes = configuration.get(IOConstants.COLUMNS_TYPES);
+ if (columnNames != null && !columnNames.isEmpty() && columnTypes != null
&& !columnTypes.isEmpty()) {
Review Comment:
Hi @difin , Thanks for checking this!
We were already importing `org.apache.hadoop.util.StringUtils` in
DataWritableReadSupport, so instead of using the fully-qualified StringUtils
naming here, i have changed it to use `StringUtils.hasLength()` from same
hadoop util in commit:
[62dcff2](https://github.com/apache/hive/pull/6506/commits/62dcff22bcce9382bd706d31942989137314b105)
Let me know if this is fine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
