difin commented on code in PR #6506: URL: https://github.com/apache/hive/pull/6506#discussion_r3530640533
########## ql/src/test/queries/clientpositive/parquet_complex_col_names.q: ########## Review Comment: Can we add additional test coverage? - Nested/complex column names with quotes inside struct/list/map types - A test to select only one column from a table that also has the quoted column, so Hive reads a pruned schema but still needs the full table schema internally - for example, with your `parquet_bps_sink` table: `select id from parquet_bps_sink order by id;` ########## ql/src/test/queries/clientpositive/parquet_complex_col_names.q: ########## Review Comment: Can we add additional test coverage? - Nested/complex column names with quotes inside struct/list/map types. - A test to select only one column from a table that also has the quoted column, so Hive reads a pruned schema but still needs the full table schema internally - for example, with your `parquet_bps_sink` table: `select id from parquet_bps_sink order by id;` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
