deniskuzZ commented on code in PR #6474:
URL: https://github.com/apache/hive/pull/6474#discussion_r3559614815
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -1681,7 +1705,11 @@ static void overlayTableProperties(Configuration
configuration, TableDesc tableD
PartitionSpec spec;
String bytes;
try {
- Table table = IcebergTableUtil.getTable(configuration, props);
+ boolean isVendedCredentials =
+ IcebergVendedCredentialUtil.requestsVendedCredentials(props,
configuration);
+ Table table = isVendedCredentials ?
Review Comment:
should we strip vended secrets from serialized table blob ?
overlayTableProperties now loads the table with vended credentials and then
calls `HiveTableUtil.serializeTable(table, ...)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
