deniskuzZ commented on code in PR #6474:
URL: https://github.com/apache/hive/pull/6474#discussion_r3560290506
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/InputFormatConfig.java:
##########
@@ -80,6 +80,12 @@ private InputFormatConfig() {
public static final String CATALOG_CONFIG_PREFIX = "iceberg.catalog.";
+ /**
+ * Base64-serialized list of {@link org.apache.iceberg.io.StorageCredential}
for Tez/LLAP executors.
+ * Stored in {@code TableDesc#jobSecrets} (HIVE-20651), not in job
properties.
+ */
+ public static final String VENDED_STORAGE_CREDENTIALS =
"iceberg.mr.vended.storage.credentials";
Review Comment:
REST catalog mints credentials at the table level for the client. So do we
need to key the credentials blob by table name —
`iceberg.mr.serialized.table.<name> ?
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/InputFormatConfig.java:
##########
@@ -80,6 +80,12 @@ private InputFormatConfig() {
public static final String CATALOG_CONFIG_PREFIX = "iceberg.catalog.";
+ /**
+ * Base64-serialized list of {@link org.apache.iceberg.io.StorageCredential}
for Tez/LLAP executors.
+ * Stored in {@code TableDesc#jobSecrets} (HIVE-20651), not in job
properties.
+ */
+ public static final String VENDED_STORAGE_CREDENTIALS =
"iceberg.mr.vended.storage.credentials";
Review Comment:
REST catalog mints credentials at the table level for the client. So do we
need to key the credentials blob by table name
—`iceberg.mr.serialized.table.<name> ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
