deniskuzZ commented on code in PR #6474:
URL: https://github.com/apache/hive/pull/6474#discussion_r3559693131
##########
ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java:
##########
@@ -861,36 +861,44 @@ private static void
configureJobPropertiesForStorageHandler(boolean input,
if (storageHandler != null) {
Map<String, String> jobProperties = new LinkedHashMap<>();
Map<String, String> jobSecrets = new LinkedHashMap<>();
- if(input) {
- try {
- storageHandler.configureInputJobProperties(
- tableDesc,
- jobProperties);
- } catch(AbstractMethodError e) {
- LOG.info("configureInputJobProperties not found "+
- "using configureTableJobProperties",e);
- storageHandler.configureTableJobProperties(tableDesc,
jobProperties);
- }
-
- try{
- storageHandler.configureInputJobCredentials(
- tableDesc,
- jobSecrets);
- } catch(AbstractMethodError e) {
- // ignore
- LOG.info("configureInputJobSecrets not found");
- }
+ if (input) {
+ try {
+ storageHandler.configureInputJobProperties(
+ tableDesc,
+ jobProperties);
+ } catch (AbstractMethodError e) {
+ LOG.info("configureInputJobProperties not found "+
+ "using configureTableJobProperties",e);
+ storageHandler.configureTableJobProperties(tableDesc,
jobProperties);
+ }
+
+ try {
+ storageHandler.configureInputJobCredentials(
+ tableDesc,
+ jobSecrets);
+ } catch (AbstractMethodError e) {
+ // ignore
+ LOG.info("configureInputJobSecrets not found");
+ }
}
else {
- try {
- storageHandler.configureOutputJobProperties(
- tableDesc,
- jobProperties);
- } catch(AbstractMethodError e) {
- LOG.info("configureOutputJobProperties not found"+
- "using configureTableJobProperties",e);
- storageHandler.configureTableJobProperties(tableDesc,
jobProperties);
- }
+ try {
+ storageHandler.configureOutputJobProperties(
+ tableDesc,
+ jobProperties);
+ } catch (AbstractMethodError e) {
+ LOG.info("configureOutputJobProperties not found"+
+ "using configureTableJobProperties",e);
+ storageHandler.configureTableJobProperties(tableDesc,
jobProperties);
+ }
+
+ try {
+ storageHandler.configureInputJobCredentials(
Review Comment:
is that really needed?
can we move it to FileSinkOperator?
````
private void copyTableSecretsAndJobPropertiesToConf(JobConf job) throws
HiveException {
try {
Utilities.copyJobSecretToTableProperties(conf.getTableInfo());
} catch (IOException e) {
throw new HiveException(e);
}
Utilities.copyTableJobPropertiesToConf(conf.getTableInfo(), job);
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
