slachiewicz opened a new pull request, #6826:
URL: https://github.com/apache/hive/pull/6826
### What changes were proposed in this pull request?
Adds Thrift's `contrib/fb303/if/fb303.thrift` as
`standalone-metastore/metastore-common/include/share/fb303/if/fb303.thrift`.
The metastore-common Thrift execution already passes `-I ${basedir}/include`,
so `include "share/fb303/if/fb303.thrift"` resolves there with no change to the
IDL or the POM.
### Why are the changes needed?
The include currently resolves only through `-I ${thrift.home}`, which
requires fb303 to have been installed separately into the Thrift prefix. Thrift
no longer installs it and declined to
([THRIFT-6389](https://issues.apache.org/jira/browse/THRIFT-6389)), so
regenerating the metastore bindings needs a manual download first. Dropping
`FacebookService` itself is
[HIVE-18249](https://issues.apache.org/jira/browse/HIVE-18249).
### Does this PR introduce _any_ user-facing change?
No. The file is identical in Thrift 0.16.0 (the pinned `libthrift.version`),
0.24.0 and master.
### How was this patch tested?
Verified: `thrift -strict --gen java:beans,generated_annotations=undated
--gen cpp --gen php --gen py --gen rb` on `hive_metastore.thrift` → 1327 files,
`diff -r`-identical to the same run resolving fb303 through a
`thrift.home`-style prefix; without the file it fails with `Could not find
include file`. Run with Thrift 0.24.0; I have not run the `thriftif` Maven
profile with 0.16.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
