slachiewicz commented on PR #6826: URL: https://github.com/apache/hive/pull/6826#issuecomment-5888318622
libfb303 still has to supply the Java classes: the generated `ThriftHiveMetastore` extends `com.facebook.fb303.FacebookService`, and `BaseHandler` extends `FacebookBase`, which is hand-written in that jar. Renaming the package is wire-compatible, but it changes the supertype of `ThriftHiveMetastore.Iface` (`@Public @Stable`) and the return type of `getStatus()`, so implementers such as [waggle-dance's `FederatedHMSHandler`](https://github.com/ExpediaGroup/waggle-dance/blob/main/waggle-dance-core/src/main/java/com/hotels/bdp/waggledance/server/FederatedHMSHandler.java) and [metacat's `CatalogThriftHiveMetastore`](https://github.com/Netflix/metacat/blob/master/metacat-thrift/src/main/java/com/netflix/metacat/thrift/CatalogThriftHiveMetastore.java) would stop compiling. I'd rather keep this PR output-neutral and drop libfb303 together with `FacebookService` in [HIVE-18249](https://issues.apache.org/jira/browse/HIVE-18249) for a major release. Happy to do that follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
