InvisibleProgrammer commented on PR #6826: URL: https://github.com/apache/hive/pull/6826#issuecomment-5890415172
It is only half way of the work. I faced with the same working on the thrift upgrade and made the same conclusion at my thrift upgrade PR here: https://github.com/apache/hive/pull/6653 Let me draw your attention on this commit specifically: https://github.com/apache/hive/pull/6653/changes/8aadf78fcb00d69d2bfa307568df68dd63cf5428 It is not only adds the thrift file but also removes the existing dependencies as well. And I think this change is required too: https://github.com/apache/hive/pull/6653/changes#diff-deb369624f92d4833d1c243ccd5f97cac71a281cf39b7326bda9a1013fac728aL25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
