abstractdog commented on code in PR #6793:
URL: https://github.com/apache/hive/pull/6793#discussion_r4184048111
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapInputFormat.java:
##########
@@ -123,19 +125,15 @@ public RecordReader<NullWritable, VectorizedRowBatch>
getRecordReader(
cvp, executor, sourceInputFormat, sourceSerDe, reporter, daemonConf);
if (rr == null) {
// Reader-specific incompatibility like SMB or schema evolution.
+ if (sourceInputFormat instanceof LlapCacheOnlyInputFormatInterface) {
+ LlapProxy.getIo().initCacheOnlyInputFormat(sourceInputFormat);
+ }
return sourceInputFormat.getRecordReader(split, job, reporter);
}
- // For non-vectorized operator case, wrap the reader if possible.
- RecordReader<NullWritable, VectorizedRowBatch> result = rr;
- if (!Utilities.getIsVectorized(job)) {
- result = null;
- if (HiveConf.getBoolVar(job, ConfVars.LLAP_IO_ROW_WRAPPER_ENABLED)) {
- result = wrapLlapReader(tableIncludedCols, rr, split);
- }
- if (result == null) {
- // Cannot wrap a reader for non-vectorized pipeline.
- return sourceInputFormat.getRecordReader(split, job, reporter);
- }
+ RecordReader<NullWritable, VectorizedRowBatch> result =
Review Comment:
ack, it was quite misleading that `wrapOrFallback` didn't actually fall
back, just induced circumstances to make the caller able to fallback, suggested
refactor makes sense to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
