abstractdog commented on code in PR #6793:
URL: https://github.com/apache/hive/pull/6793#discussion_r4184232313
##########
llap-client/src/java/org/apache/hadoop/hive/llap/io/api/LlapIo.java:
##########
@@ -74,11 +74,15 @@ InputFormat<NullWritable, T> getInputFormat(
* @param fileKey fileId of the Parquet file (either the Long fileId of HDFS
or the SyntheticFileId).
* Optional, if it is not provided, it will be generated, see:
* org.apache.hadoop.hive.ql.io.HdfsUtils#getFileId()
+ * @param cacheHit optional out-parameter; when supplied, its {@code value}
field is written
+ * with {@code true} on a cache hit and {@code false} on a
miss, so the caller
+ * (which lives in llap-server and holds {@code
QueryFragmentCounters}) can bump
+ * {@code METADATA_CACHE_HIT} / {@code METADATA_CACHE_MISS}
for the LLAP IO summary.
* @return
* @throws IOException
*/
- MemoryBufferOrBuffers getParquetFooterBuffersFromCache(Path path, JobConf
conf, @Nullable Object fileKey)
- throws IOException;
+ MemoryBufferOrBuffers getParquetFooterBuffersFromCache(Path path, JobConf
conf, @Nullable Object fileKey,
Review Comment:
this makes this patch even larger, but as it's already huge, I think I can
take care of it here for better code quality
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
